Merged
Conversation
Reduce precision when 2nd significant figure is always zero
Member
|
Thanks! This is a great little improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #279
The auto accuracy heuristic shows 2 significant figures, relative to the smallest difference between breaks. This is designed to handle situations like (taken from tidyverse blog post):
However, this heuristic displays an unnecessary digit in the specific case when all the breaks align with zeros in the final digit. This situation naturally occurs very often. Here's an example (taken from the scales docs):
This PR reduces the precision when final digit is always zero.
Before
Created on 2021-03-27 by the reprex package (v1.0.0)
After
Created on 2021-03-27 by the reprex package (v1.0.0)