New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dollar and percent to return zero length output on zero length input #35

Merged
merged 2 commits into from Jun 11, 2015

Conversation

Projects
None yet
2 participants
@BrianDiggs
Contributor

BrianDiggs commented Jan 29, 2013

Actual change in dollar_format and percent_format which carry
over to dollar and percent.

Added tests which cover all formatters and format generators to
make sure zero length input gives zero length output.

Fixes #34

@hadley

This comment has been minimized.

Member

hadley commented Jun 10, 2015

Could you please merge/rebase and add a bullet to NEWS?

BrianDiggs added some commits Jan 29, 2013

Fix dollar and percent to return zero length output on zero length input
Actual change in dollar_format and percent_format which carry
over to dollar and percent.

Added tests which cover all formatters and format generators to
make sure zero length input gives zero length output.

@BrianDiggs BrianDiggs force-pushed the BrianDiggs:fix/zero-length-format branch from b64266d to 490668a Jun 11, 2015

@BrianDiggs

This comment has been minimized.

Contributor

BrianDiggs commented Jun 11, 2015

Rebased and it passes Travis CI.

hadley added a commit that referenced this pull request Jun 11, 2015

Merge pull request #35 from BrianDiggs/fix/zero-length-format
Fix dollar and percent to return zero length output on zero length input

@hadley hadley merged commit d2ede0b into r-lib:master Jun 11, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Member

hadley commented Jun 11, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment