Allow to reverse the order of colours in a brewer palette#36
Allow to reverse the order of colours in a brewer palette#36hadley merged 2 commits intor-lib:masterfrom
Conversation
|
Could you please merge/rebase and add a bullet to NEWS? |
8a9944c to
316ca6a
Compare
Use the same argument name as hue_pal: direction
316ca6a to
20161ad
Compare
|
Done, and squashed everything into one commit. |
|
I forgot to write the documentation before. Sorry. |
|
It passed! It'll be great if you can merge it before the release so that I can depend on it in ggplot2. |
There was a problem hiding this comment.
For future reference, I prefer to use return() only for early returns
There was a problem hiding this comment.
OK. I thought it was good practice to always have an explicit return()(it's certainly less confusing for newcomers/students in my experience).
Allow to reverse the order of colours in a brewer palette
|
Thanks! |
|
BTW if you have a little more time, I'd love a PR with some tests :) |
|
What would you want me to test in this particular instance? The order of colors returned? The values of colors returned? |
|
Thanks for merging it anyway, I'll get to work on the ggplot end now! |
Use the same argument that hue_pal uses: direction