New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a tz parameter to the date_format function #51

Merged
merged 4 commits into from Jun 10, 2015

Conversation

Projects
None yet
2 participants
@dvmlls
Contributor

dvmlls commented Oct 14, 2014

No description provided.

#' @export
date_format <- function(format = "%Y-%m-%d") {
function(x) format(x, format)
date_format <- function(format = "%Y-%m-%d", tz='UTC') {

This comment has been minimized.

@hadley

hadley Jun 10, 2015

Member

Could you please add spaces around =?

@hadley

This comment has been minimized.

Member

hadley commented Jun 10, 2015

Could you please also add a bullet to NEWS?

dvmlls added some commits Jun 10, 2015

hadley added a commit that referenced this pull request Jun 10, 2015

Merge pull request #51 from dvmlls/master
add a tz parameter to the date_format function

@hadley hadley merged commit fafd9aa into r-lib:master Jun 10, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@hadley

This comment has been minimized.

Member

hadley commented Jun 10, 2015

Perfect - thanks!

@dvmlls

This comment has been minimized.

Contributor

dvmlls commented Jun 10, 2015

No no, thank you sir!

These packages are terrific.

On Wed, Jun 10, 2015 at 4:28 PM, Hadley Wickham notifications@github.com
wrote:

Perfect - thanks!


Reply to this email directly or view it on GitHub
#51 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment