Update CRAN comments and version for next release#96
Merged
karawoo merged 4 commits intor-lib:masterfrom Aug 23, 2017
Merged
Conversation
hadley
reviewed
Aug 11, 2017
DESCRIPTION
Outdated
| @@ -1,5 +1,5 @@ | |||
| Package: scales | |||
| Version: 0.4.1.9002 | |||
| Version: 0.5.1 | |||
cran-comments.md
Outdated
| ## Reverse dependencies | ||
|
|
||
| This was minor release that only added new features, but I ran revdep checks on the 160 reverse dependencies just to be sure (complete results at https://github.com/hadley/scales/blob/master/revdep). I saw no problems related to scales. | ||
| I ran revdep checks on the 272 reverse dependencies (complete results at https://github.com/hadley/scales/blob/master/revdep). There were issues with three packages; one of these issues appears unrelated to `scales`. |
Collaborator
Author
There was a problem hiding this comment.
Yes, for DiagrammeR and incidence.
Member
There was a problem hiding this comment.
In that case, I think you're probably providing a bit too much detail to CRAN. You can just say "the maintainers were informed of these issues on xxx xxxxx xxx". CRAN mainly wants to know that you've done due diligence.
DiagrammeR is fixed, so only one package has an issue now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In prep for the next release of
scalesI've updated the version number and cran-comments.md. Is this the right information to include? This will be my first CRAN submission 😮 so I'm not sure what info they need.Also I might've misinterpreted the instructions in our doc—I only built on Windows with R-devel, not R-release. Let me know if you want me to re-do that on both.