New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRAN Submission schedule for new version of styler #338
Milestone
Comments
Would be good to release enc by then. Would you mind adding a versioned dependency (>= 0.1-10) and a remote to The timing is fine, too. |
If the API hasn't changed at all, 1.0.1 should be fine. |
lorenzwalthert
added a commit
to lorenzwalthert/styler
that referenced
this issue
Feb 3, 2018
lorenzwalthert
added a commit
to lorenzwalthert/styler
that referenced
this issue
Feb 4, 2018
lorenzwalthert
added a commit
to lorenzwalthert/styler
that referenced
this issue
Feb 9, 2018
lorenzwalthert
added a commit
to lorenzwalthert/styler
that referenced
this issue
Feb 9, 2018
Yes, dependency added. |
lorenzwalthert
added a commit
to lorenzwalthert/styler
that referenced
this issue
Feb 9, 2018
Merged
lorenzwalthert
added a commit
to lorenzwalthert/styler
that referenced
this issue
Feb 10, 2018
lorenzwalthert
added a commit
to lorenzwalthert/styler
that referenced
this issue
Feb 22, 2018
lorenzwalthert
added a commit
to lorenzwalthert/styler
that referenced
this issue
Feb 23, 2018
lorenzwalthert
added a commit
to lorenzwalthert/styler
that referenced
this issue
Feb 24, 2018
lorenzwalthert
added a commit
that referenced
this issue
Feb 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since the initial release of styler, some important bugs were fixed:
dplyr
dependency was removed (remove implicit dplyr dependency #324).=
assignment does no longer cause errors (Fixing relocation of EQ_ASSIGN #328).purrr
added to DESCRIPTION (map_dfr() needs purrr 0.2.3 #326).style_pkg()
and friends was fixed.enc
the patch is not included in the current CRAN version (as of February 3, 2018).In addition, there were other enhancements / improvements contributed to styler (most notably #318, #316, #311, #306, #304), and
Since styler reverse depends on
usethis
, which will become adevtools
dependency with the next release ofdevtools
, we should ensure that by the time of this release, the above bugfixes are included in the CRAN version of styler.Therefore, I suggest to submit styler
1.0.1
mid February, which seems in accordance with the CRAN Policy. @krlmlr Do you agree with this timing and the version number (or should we do1.1
)? Do you think a new release ofenc
is also required?The text was updated successfully, but these errors were encountered: