Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN Submission schedule for new version of styler #338

Closed
lorenzwalthert opened this Issue Feb 3, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@lorenzwalthert
Copy link
Collaborator

lorenzwalthert commented Feb 3, 2018

Since the initial release of styler, some important bugs were fixed:

  • implicit dplyr dependency was removed (#324).
  • cascading = assignment does no longer cause errors (#328).
  • minimal version of purrr added to DESCRIPTION (#326).
  • An annoying spelling mistake in the output sent to the console after running style_pkg() and friends was fixed.
  • A bug that resulted in a removal of non-ASCIII characters was fixed in the dependency enc the patch is not included in the current CRAN version (as of February 3, 2018).

In addition, there were other enhancements / improvements contributed to styler (most notably #318, #316, #311, #306, #304), and

Since styler reverse depends on usethis, which will become a devtools dependency with the next release of devtools, we should ensure that by the time of this release, the above bugfixes are included in the CRAN version of styler.

Therefore, I suggest to submit styler 1.0.1 mid February, which seems in accordance with the CRAN Policy. @krlmlr Do you agree with this timing and the version number (or should we do 1.1)? Do you think a new release of enc is also required?

@krlmlr

This comment has been minimized.

Copy link
Member

krlmlr commented Feb 3, 2018

Would be good to release enc by then. Would you mind adding a versioned dependency (>= 0.1-10) and a remote to DESCRIPTION?

The timing is fine, too.

@krlmlr

This comment has been minimized.

Copy link
Member

krlmlr commented Feb 3, 2018

If the API hasn't changed at all, 1.0.1 should be fine.

lorenzwalthert added a commit to lorenzwalthert/styler that referenced this issue Feb 3, 2018

@lorenzwalthert lorenzwalthert added this to the CRAN (styler 1.0.1) milestone Feb 4, 2018

lorenzwalthert added a commit to lorenzwalthert/styler that referenced this issue Feb 4, 2018

lorenzwalthert added a commit to lorenzwalthert/styler that referenced this issue Feb 9, 2018

lorenzwalthert added a commit to lorenzwalthert/styler that referenced this issue Feb 9, 2018

@lorenzwalthert

This comment has been minimized.

Copy link
Collaborator Author

lorenzwalthert commented Feb 9, 2018

Yes, dependency added.

lorenzwalthert added a commit to lorenzwalthert/styler that referenced this issue Feb 9, 2018

lorenzwalthert added a commit to lorenzwalthert/styler that referenced this issue Feb 10, 2018

lorenzwalthert added a commit to lorenzwalthert/styler that referenced this issue Feb 22, 2018

lorenzwalthert added a commit to lorenzwalthert/styler that referenced this issue Feb 23, 2018

lorenzwalthert added a commit to lorenzwalthert/styler that referenced this issue Feb 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.