Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style_file breaks hash-bang statement at top of script #344

Closed
jjramsey opened this Issue Feb 5, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@jjramsey
Copy link

jjramsey commented Feb 5, 2018

If at the top of a script, there's a line that reads "#!/usr/bin/env Rscript", style_file will change it to

# !/usr/bin/env Rscript

with a space after the "#". This prevents the script from being executed unless that extra space is removed. Not the end of the world but really annoying.

@lorenzwalthert lorenzwalthert referenced this issue Feb 5, 2018

Merged

Shebang #345

@lorenzwalthert

This comment has been minimized.

Copy link
Collaborator

lorenzwalthert commented Feb 5, 2018

Thanks @jjramsey, I did not think of that use case when I implemented that functionality. We could use regex to filter has-bang statements from the comments and avoid adding spaces to them after #. I outlined that in #345. Your comments, especially with regard to the proposed regex are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.