New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upcoming fix in R devel parser requires action #419
Comments
Thanks for looking into this. Can you send Tomas an We have r-devel on Travis, so we'll see there if it works. At some point we need to update on CRAN, but we might be able to wait until early next year. |
Ok. I suggest to just wait then and prepare a new release so we can submit to CRAN as soon as committed into devel. |
Sure I can test an updated source package for you on my system. There may be some more changes you'd need to make if your code assumes that the node for equality assignment is |
Thanks Tomas. I'd like to use your patch but I am a bit afraid of building R devel from source myself if this is required at all. Is it? I run macOs, Linux and Windows. |
Decision: Wait until on R devel and fix it then. |
Note the new token, which is not an
expr
and that all ids are changed. I was notified by the creator of the bug fix Tomas Kalibera as this will causeR CMD CHECK
of styler (and reverse dependencies) to fail on R devel.I see the following solution: Nest the parse data as is. Then, don't relocate the
EQ_ASSIGN
if a tokenequal_assign
is present in a nest.@krlmlr what do you think should we do? Should we wait until the bug fix of the base R parser is implemented in R devel, fix the problem here and create a new release? I think I can't guarantee that this works and submit before the changes are implemented in R devel and I won't build R devel myself.
The text was updated successfully, but these errors were encountered: