New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

styler writes file even if content does not change #531

Closed

lorenzwalthert opened this issue Jul 9, 2019 · 0 comments · Fixed by #532

Labels

Complexity: Low Priority: High Status: Unassigned Type: Bug

Collaborator

lorenzwalthert commented Jul 9, 2019

https://github.com/r-lib/styler/blob/master/R/io.R#L21. This causes a problem in an edge case with pre-commit-hooks as the styler styling hook would always README.Rmd but not its .md counterpart, and when trying to ensure .md was last modified after .Rmd, it fails. See pre-commit/pre-commit#1080.

lorenzwalthert mentioned this issue

Only write back when contents changed #532

Merged

lorenzwalthert closed this as completed in #532

lorenzwalthert added Complexity: Low Priority: High Status: Unassigned Type: Bug labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment