Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify styler_df() signature #1009

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Simplify styler_df() signature #1009

merged 2 commits into from
Sep 28, 2022

Conversation

IndrajeetPatil
Copy link
Collaborator

This is generating warnings.

Follow-up on #1007

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if f0a3a08 is merged into main:

  •   :ballot_box_with_check:cache_applying: 32.1ms -> 31.9ms [-1.39%, +0.49%]
  •   :ballot_box_with_check:cache_recording: 850ms -> 846ms [-1.16%, +0.16%]
  •   :ballot_box_with_check:without_cache: 2.12s -> 2.12s [-0.23%, +0.95%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@krlmlr
Copy link
Member

krlmlr commented Sep 28, 2022

What kinds of warning are we seeing here?

@IndrajeetPatil
Copy link
Collaborator Author

Strange. I can't reproduce this anymore.

I think the PR is still worth considering, though, for simplifying the wrapper function styler_df(). We don't need to provide any other args to it than ....

@IndrajeetPatil IndrajeetPatil changed the title Get rid of unnecessary .name_repair arg Simplify styler_df() signature Sep 28, 2022
@IndrajeetPatil IndrajeetPatil merged commit 35519b9 into r-lib:main Sep 28, 2022
@IndrajeetPatil IndrajeetPatil deleted the rm_warning_1007_followup branch September 28, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants