Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave comments on line after { #1022

Merged
merged 5 commits into from
Oct 4, 2022
Merged

Leave comments on line after { #1022

merged 5 commits into from
Oct 4, 2022

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Oct 4, 2022

Closes #1004.

@IndrajeetPatil
Copy link
Collaborator

Yikes, why isn't the benchmarking working?!

Oh, IINM, YAML is case-sensitive, right? So we need to change this to - "R/**"?

@lorenzwalthert
Copy link
Collaborator Author

lorenzwalthert commented Oct 4, 2022

I would assume YAML is case sensitive and parses "r/**" to "r/**". Question is more if GitHub Actions syntax is case sensitive for on: -> paths.

@lorenzwalthert
Copy link
Collaborator Author

@IndrajeetPatil seems to work now with {touchstone}, committed directly to main.

@codecov-commenter
Copy link

Codecov Report

Merging #1022 (4a847f5) into main (08a3850) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1022   +/-   ##
=======================================
  Coverage   91.20%   91.20%           
=======================================
  Files          46       46           
  Lines        2682     2683    +1     
=======================================
+ Hits         2446     2447    +1     
  Misses        236      236           
Impacted Files Coverage Δ
R/rules-line-breaks.R 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 48d31bd is merged into main:

  •   :ballot_box_with_check:cache_applying: 35.6ms -> 35.3ms [-1.85%, +0.32%]
  •   :ballot_box_with_check:cache_recording: 944ms -> 948ms [-0.17%, +0.93%]
  •   :ballot_box_with_check:without_cache: 2.38s -> 2.37s [-0.69%, +0.26%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@IndrajeetPatil IndrajeetPatil merged commit f74502f into main Oct 4, 2022
@IndrajeetPatil IndrajeetPatil deleted the issue-1004 branch October 4, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment positions not preserved when preceded by a brace ({)
3 participants