Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply rules for [ to [[ and its closing counterpair #1030

Merged
merged 6 commits into from
Oct 15, 2022
Merged

Conversation

lorenzwalthert
Copy link
Collaborator

Closes #1029.

@lorenzwalthert lorenzwalthert marked this pull request as draft October 15, 2022 11:21
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2022

Codecov Report

Merging #1030 (a6ebe75) into main (c6b978b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1030      +/-   ##
==========================================
+ Coverage   91.20%   91.21%   +0.01%     
==========================================
  Files          46       46              
  Lines        2683     2687       +4     
==========================================
+ Hits         2447     2451       +4     
  Misses        236      236              
Impacted Files Coverage Δ
R/token-define.R 66.66% <ø> (ø)
R/expr-is.R 86.11% <100.00%> (ø)
R/indent.R 100.00% <100.00%> (ø)
R/rules-indention.R 100.00% <100.00%> (ø)
R/rules-line-breaks.R 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lorenzwalthert lorenzwalthert changed the title apply rules for [ to [[ and it's closing counterpair apply rules for [ to [[ and its closing counterpair Oct 15, 2022
R/indent.R Outdated Show resolved Hide resolved
Co-authored-by: Indrajeet Patil <patilindrajeet.science@gmail.com>
@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 31e7f6b is merged into main:

  •   :ballot_box_with_check:cache_applying: 40.3ms -> 39.9ms [-3.58%, +1.74%]
  •   :ballot_box_with_check:cache_recording: 1.14s -> 1.15s [-1.15%, +2.31%]
  •   :ballot_box_with_check:without_cache: 2.88s -> 2.85s [-3.1%, +0.97%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 673585b is merged into main:

  •   :ballot_box_with_check:cache_applying: 25.8ms -> 25.8ms [-0.92%, +1.09%]
  •   :ballot_box_with_check:cache_recording: 703ms -> 703ms [-0.3%, +0.34%]
  •   :ballot_box_with_check:without_cache: 1.75s -> 1.75s [-0.37%, +0.33%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert marked this pull request as ready for review October 15, 2022 14:48
@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8a94436 is merged into main:

  •   :ballot_box_with_check:cache_applying: 35.6ms -> 35.5ms [-3.28%, +2.39%]
  •   :ballot_box_with_check:cache_recording: 964ms -> 961ms [-2.74%, +1.97%]
  •   :ballot_box_with_check:without_cache: 2.38s -> 2.41s [-0.91%, +3.17%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency of indention for [[
3 participants