Skip to content

Fix alignment detection for one column, mixed named/unnamed #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2022

Conversation

lorenzwalthert
Copy link
Collaborator

Closes #984.

Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

Just one minor nit to address.

Co-authored-by: Indrajeet Patil <patilindrajeet.science@gmail.com>
@lorenzwalthert
Copy link
Collaborator Author

right... I think it's time to activate the lintr pre-commit hook so my float subsetting does not start to crumble your conutless changes in that field.

@codecov-commenter
Copy link

Codecov Report

Merging #1035 (d24fcfa) into main (305644b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1035   +/-   ##
=======================================
  Coverage   91.08%   91.08%           
=======================================
  Files          46       46           
  Lines        2691     2691           
=======================================
  Hits         2451     2451           
  Misses        240      240           
Impacted Files Coverage Δ
R/detect-alignment.R 97.80% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lorenzwalthert lorenzwalthert merged commit 990a031 into main Oct 22, 2022
@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8e39777 is merged into main:

  •   :rocket:cache_applying: 31.9ms -> 28.4ms [-13.7%, -8.07%]
  •   :ballot_box_with_check:cache_recording: 850ms -> 850ms [-1.39%, +1.42%]
  •   :ballot_box_with_check:without_cache: 2.12s -> 2.11s [-1.52%, +0.58%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert deleted the issue-984 branch October 22, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Superfluous whitespace in named function arguments is not removed
3 participants