Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only run {pkgapi} if available #1039

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Only run {pkgapi} if available #1039

merged 2 commits into from
Oct 24, 2022

Conversation

lorenzwalthert
Copy link
Collaborator

Taken from {precommit}.

@lorenzwalthert lorenzwalthert changed the title Only run pkgapi if available Only run {pkgapi} if available Oct 24, 2022
IndrajeetPatil
IndrajeetPatil approved these changes Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

@lorenzwalthert lorenzwalthert merged commit a760cfb into main Oct 24, 2022
@lorenzwalthert lorenzwalthert deleted the pkgapi branch October 24, 2022 10:34
@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 066116a is merged into main:

  •   :rocket:cache_applying: 27.6ms -> 25.5ms [-11.27%, -4.13%]
  •   :ballot_box_with_check:cache_recording: 769ms -> 768ms [-1.46%, +1.13%]
  •   :ballot_box_with_check:without_cache: 1.94s -> 1.94s [-1.9%, +1.51%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IndrajeetPatil IndrajeetPatil IndrajeetPatil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorenzwalthert @IndrajeetPatil