Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify caching internal's conditionals with rlang::%||% #1041

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

IndrajeetPatil
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if e46a2f6 is merged into main:

  •   :rocket:cache_applying: 26.4ms -> 24.3ms [-10.1%, -6.12%]
  •   :ballot_box_with_check:cache_recording: 761ms -> 762ms [-0.37%, +0.61%]
  •   :ballot_box_with_check:without_cache: 1.93s -> 1.92s [-0.59%, +0.4%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if e46a2f6 is merged into main:

  •   :rocket:cache_applying: 33ms -> 30.4ms [-10.32%, -5.74%]
  •   :ballot_box_with_check:cache_recording: 946ms -> 944ms [-0.93%, +0.38%]
  •   :ballot_box_with_check:without_cache: 2.38s -> 2.38s [-1%, +0.47%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert changed the title Minor code cleanup for caching-related functions Simplify caching internals with rlang::%||% Oct 26, 2022
@lorenzwalthert lorenzwalthert changed the title Simplify caching internals with rlang::%||% Simplify caching internal's conditionals with rlang::%||% Oct 26, 2022
@IndrajeetPatil IndrajeetPatil merged commit a45f667 into main Oct 26, 2022
@IndrajeetPatil IndrajeetPatil deleted the cache_minor_cleanup branch October 26, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants