Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve YAML formatting for pkgdown #1042

Merged
merged 3 commits into from
Oct 27, 2022
Merged

Conversation

IndrajeetPatil
Copy link
Collaborator

Also rename fileext: yml -> yaml

Also rename fileext: yml -> yaml
@codecov-commenter
Copy link

Codecov Report

Merging #1042 (381a6e3) into main (305644b) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 381a6e3 differs from pull request most recent head 4484cfb. Consider uploading reports for the commit 4484cfb to get more accurate results

@@           Coverage Diff           @@
##             main    #1042   +/-   ##
=======================================
  Coverage   91.08%   91.08%           
=======================================
  Files          46       46           
  Lines        2691     2691           
=======================================
  Hits         2451     2451           
  Misses        240      240           
Impacted Files Coverage Δ
R/detect-alignment.R 97.80% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lorenzwalthert
Copy link
Collaborator

Did you use a formatter or format manually?

@IndrajeetPatil
Copy link
Collaborator Author

I used VS Code's YAML formatter

@IndrajeetPatil
Copy link
Collaborator Author

@lorenzwalthert Did you need any further clarifications on this PR?

@lorenzwalthert
Copy link
Collaborator

No. I was wondering if we should add a pre-commit hook for YAML formatting (and I remembered there weren’t any popularones at the time I checked last time) and I found the there is one by Google now and I might use it in the future (google/yamlfmt#58).

@IndrajeetPatil IndrajeetPatil merged commit 4c1cb51 into main Oct 27, 2022
@IndrajeetPatil IndrajeetPatil deleted the pkgdown_yaml_formatting branch October 27, 2022 13:26
@IndrajeetPatil
Copy link
Collaborator Author

That'd indeed be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants