Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use integer literals where needed #1054

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Conversation

IndrajeetPatil
Copy link
Collaborator

A few I missed out on in previous PRs.

A few I missed out on in previous PRs.
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 63149cb is merged into main:

  •   :ballot_box_with_check:cache_applying: 18.7ms -> 18.7ms [-0.65%, +0.96%]
  •   :ballot_box_with_check:cache_recording: 626ms -> 622ms [-1.59%, +0.27%]
  •   :ballot_box_with_check:without_cache: 1.6s -> 1.59s [-1.58%, +1.06%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert
Copy link
Collaborator

Agree. Let's activate the pre-commit hook before we introduce more of those.

@IndrajeetPatil IndrajeetPatil merged commit e75bcf1 into main Nov 8, 2022
@IndrajeetPatil IndrajeetPatil deleted the remaining_integer_literals branch November 8, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants