-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document imports in a single file #1060
Conversation
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 765e837 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Ok. I am not sure that’s the best way though. Just as context: at the very beginning, we imported all objects on a function basis. That’s why there are many duplicated statements. It reminds me now of the Python import style. The good thing about the duplication is that if a function call looks unknown, you can see quickly check the roxygen comments to know where it comes from. But since we anyways mostly imported functions that developers know, and prefixed the more exotic lines with |
I guess the PR makes sense mostly though. Maybe some of the functions that are just used once and that are more exotic like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
write.table
and capture.output
could be prefixed, these are not used at runtime anyways, only for testing.
@@ -18,15 +18,24 @@ | |||
#' style_text("a%>%b; a", scope = "tokens") | |||
"_PACKAGE" | |||
|
|||
if (getRversion() >= "2.15.1") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This conditional is unnecessary since it will always be true.
I have done so now.
Each |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 1f8474b is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Note that the
NAMESPACE
file remains unchanged.This is similar to the idiom utilized by
{usethis}
package.