-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add {lintr}
precommit hook and remove existing lints
#1064
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1064 +/- ##
=======================================
Coverage 91.05% 91.06%
=======================================
Files 46 46
Lines 2682 2685 +3
=======================================
+ Hits 2442 2445 +3
Misses 240 240
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
{lintr}
precommit hook{lintr}
precommit hook and remove existing lints
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8a63d95 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8a63d95 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
if you don't want to keep pushing and waiting, just run |
Thanks. This PR needs to wait until #1065 is resolved. |
@lorenzwalthert Any ideas what this error is about? Error in `precommit::roxygenize_with_cache()`:
! invalid 'expand' argument
Backtrace:
▆
1. └─precommit::roxygenize_with_cache(key = wd, dirs = path_relative_cache)
2. └─rlang::abort(conditionMessage(out)) |
ugh... No, I don't know. |
I think I figured out what was causing the issue. Let's see if the builds pass now. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8a63d95 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Glad you found the issue. Is that relevant for the CRAN version in any way? Ie could the user get the same an error? |
No, no, I had messed up some code while working on the PR, and that's why it was failing. All good now. |
Closes #1055