-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If function declarations are double indented, leave it #1083
Conversation
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 93914e4 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
…ble indention, only symbol formals count
6d9c346
to
24a44b7
Compare
Codecov Report
@@ Coverage Diff @@
## main #1083 +/- ##
==========================================
- Coverage 91.10% 91.07% -0.04%
==========================================
Files 46 46
Lines 2699 2711 +12
==========================================
+ Hits 2459 2469 +10
- Misses 240 242 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 93914e4 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
8040923
to
d404a4e
Compare
This is how benchmark results would change (along with a 95% confidence interval in relative change) if cb09801 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 0b34e99 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Co-authored-by: Indrajeet Patil <patilindrajeet.science@gmail.com>
@lorenzwalthert Overall looks good to me. I just had one comment. Currently, as seen in one of the test cases, the following code function(a =
b,
f =
d, c =
3, d =
4) {
} is styled to function(a =
b,
f =
d, c =
3, d =
4) {
} Shouldn't it instead be styled to? function(a =
b,
f =
d,
c =
3,
d =
4) {
} Or is the advice of one argument per line here relevant only when the arguments are long? |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 196d31a is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
I don't know. Probably it's meant to be one argument per line or all arguments on one line. But I think this has not really to do with the PR directly, so if you care about it, I suggest to open a new issue. |
Closes #845.