Skip to content

Bump benchmark config #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Bump benchmark config #1104

merged 1 commit into from
Apr 4, 2023

Conversation

lorenzwalthert
Copy link
Collaborator

@IndrajeetPatil Seems like try_fetch() got a lot faster recently. When I made a benchmark run, it was much faster than with_handlers():

library(rlang)
bench::mark(
  rlang::with_handlers({}, error = function(...) NULL),
  rlang::try_fetch({}, error = function(...) NULL),
)
#> Warning: `with_handlers()` is deprecated as of rlang 1.0.0.
#> ℹ Please use `tryCatch()`, `withCallingHandlers()`, or `try_fetch()`.
#> This warning is displayed once every 8 hours.
#> # A tibble: 2 × 6
#>   expression                                                 min  median itr/s…¹
#>   <bch:expr>                                            <bch:tm> <bch:t>   <dbl>
#> 1 rlang::with_handlers({ }, error = function(...) NULL)   6.37ms  6.47ms    152.
#> 2 rlang::try_fetch({ }, error = function(...) NULL)      10.75µs 11.62µs  84532.
#> # … with 2 more variables: mem_alloc <bch:byt>, `gc/sec` <dbl>, and abbreviated
#> #   variable name ¹​`itr/sec`

Created on 2023-04-04 with reprex v2.0.2

I am bumping the benchmarking deps here, let's see what they bring and then, you can rebase #1103 on main to see if the problem persists.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 57bbf4e is merged into main:

  •   :ballot_box_with_check:cache_applying: 88.9ms -> 88ms [-6.77%, +4.73%]
  •   :ballot_box_with_check:cache_recording: 1.23s -> 1.26s [-2.46%, +6.13%]
  •   :ballot_box_with_check:without_cache: 3.03s -> 3.01s [-4.99%, +3.3%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@IndrajeetPatil
Copy link
Collaborator

Why are all the workflows failing?! I can't seem to see the entirety of the logs, which is probably a bug in GHA UI.

@lorenzwalthert lorenzwalthert merged commit 92b3d08 into main Apr 4, 2023
@lorenzwalthert lorenzwalthert deleted the touchstone-update-deps branch April 4, 2023 08:25
@lorenzwalthert
Copy link
Collaborator Author

Why are all the workflows failing?

Because of the testthat warnings due to the deprecated with_handlers()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants