-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer vctrs functions over slower base R equivalents #1114
Conversation
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 940010d is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Next in line: replacing |
And |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 0c4187c is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Gone now. |
Will conflict with #1112, but I can handle that. |
Codecov Report
@@ Coverage Diff @@
## main #1114 +/- ##
==========================================
- Coverage 91.07% 91.07% -0.01%
==========================================
Files 46 46
Lines 2713 2701 -12
==========================================
- Hits 2471 2460 -11
+ Misses 242 241 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 0592e8e is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 0592e8e is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 0592e8e is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 0592e8e is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 0592e8e is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 0592e8e is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Finally green. Force-pushed, with meaningful individual commits. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 0592e8e is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Super-green. Greener than green. |
Great @krlmlr. I was wondering: Do we want to replace all / more of |
Good catch! |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if e5ecef7 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. 🥳
for performance.