Skip to content

docs: Document package options - #1193

Merged
lorenzwalthert merged 3 commits into
mainfrom
1185-docs-options
Apr 21, 2024
Merged

lorenzwalthert merged 3 commits into
mainfrom
1185-docs-options

Conversation

@IndrajeetPatil

Copy link
Copy Markdown
Collaborator

Closes #1185

@github-actions

Copy link
Copy Markdown
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 9416b3b is merged into main:

  • ❗🐌cache_applying: 167ms -> 170ms [+0.12%, +3.9%]
  • ❗🐌cache_recording: 533ms -> 539ms [+0.53%, +1.91%]
  • ✔️without_cache: 1.01s -> 1.01s [-1.1%, +0.05%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, a few suggestions to improve things further. I think {pkgdown} should pick up these if you stick to the suggested syntax, according to the docs.

Comment thread R/options.R Outdated
#'
#' - `styler.cache_name`: character.
#' The name of the styler cache to use.
#' (default: current styler package version)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could actually put the version here, since roxygen comments can now contain R code to evaluate.

Comment thread R/options.R
#'
#' - `styler.cache_root`: character.
#' The directory where the cache files are stored.
#' (default: `NULL`)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could link help("caching") here.

Comment thread R/options.R
#'
#' - `styler.ignore_alignment`: logical.
#' If `TRUE`, alignment, when detected, is ignored.
#' (default: `FALSE`)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could link vignette("detect-alignment") here.

Comment thread R/options.R
#'
#' - `styler.ignore_start`, `styler.ignore_stop`: character.
#' Regular expressions to ignore lines that match them.
#' (default: `"styler: off"` and `"styler: on"`, respectively)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can link help("stylerignore") here.

@github-actions

Copy link
Copy Markdown
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 9416b3b is merged into main:

  • ✔️cache_applying: 143ms -> 144ms [-0.64%, +1.24%]
  • ✔️cache_recording: 509ms -> 510ms [-0.7%, +1.11%]
  • ✔️without_cache: 965ms -> 967ms [-0.2%, +0.46%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert

Copy link
Copy Markdown
Collaborator

Thanks. Great addition to our docs.

@lorenzwalthert
lorenzwalthert merged commit 932437b into main Apr 21, 2024
@lorenzwalthert
lorenzwalthert deleted the 1185-docs-options branch April 21, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document options

2 participants