Remove unused testing helper: generate_test_samples() - #1212
Merged
Conversation
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 4f78252 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Collaborator
|
Hmmmm... Not sure we actually want to remove these functions. I think Kirill deliberately committed these generators, not sure maybe he thought we'd later change them later to re-generate tests. Hasn't happened though... I guess we can remove them, and come back here in case we need them. |
lorenzwalthert
approved these changes
May 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.