Skip to content

Remove unused testing helper: generate_test_samples() - #1212

Merged
IndrajeetPatil merged 2 commits into
mainfrom
rm-generate_test_samples
May 23, 2024
Merged

Remove unused testing helper: generate_test_samples()#1212
IndrajeetPatil merged 2 commits into
mainfrom
rm-generate_test_samples

Conversation

@IndrajeetPatil

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

Copy link
Copy Markdown
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 4f78252 is merged into main:

  • ✔️cache_applying: 152ms -> 155ms [-3.81%, +6.79%]
  • ✔️cache_recording: 547ms -> 542ms [-5.51%, +3.92%]
  • ✔️without_cache: 943ms -> 939ms [-0.73%, +0.03%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert

Copy link
Copy Markdown
Collaborator

Hmmmm... Not sure we actually want to remove these functions. I think Kirill deliberately committed these generators, not sure maybe he thought we'd later change them later to re-generate tests. Hasn't happened though... I guess we can remove them, and come back here in case we need them.

@IndrajeetPatil
IndrajeetPatil merged commit 3394099 into main May 23, 2024
@IndrajeetPatil
IndrajeetPatil deleted the rm-generate_test_samples branch May 23, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants