Avoid spaces around ^

[krlmlr]

following tidyverse/style#46.

[codecov-io]

Codecov Report

Merging #308 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
+ Coverage   91.35%   91.36%   +0.01%     
==========================================
  Files          30       30              
  Lines        1399     1402       +3     
==========================================
+ Hits         1278     1281       +3     
  Misses        121      121

Impacted Files	Coverage Δ
R/style_guides.R	96.8% <100%> (+0.07%)	⬆️
R/rules-spacing.R	96.07% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49621d9...0c7e298. Read the comment docs.

[lorenzwalthert]

Aren't we changing the defaults in specify_math_token_spacing()? Because currently, all the defaults correspond to the tidyverse style guide. Or do you consider that API change as too disruptive?

[krlmlr]

I meant to change the default, the tidyverse style guide now contains the rules for ^. What am I missing?

[lorenzwalthert]

I thought we change the default value in the function declaration of specify_math_token_spacing() (I.e. here: https://github.com/r-lib/styler/pull/308/files#diff-fefe826487d2bf7becb27b255b8bd8dfR304) , not in the function call.

[krlmlr]

I have no idea why this happens:

styler::style_text("1 - 3 * 4 ^ 5", strict = FALSE)
#> 1 - 3 * 4 ^ 5

[lorenzwalthert]

That's actually what I'd expect because strict = FALSE means no strict implementation, right? Or do you prefer to set the spaces to exactly zero around ^ even if strict = FALSE?

[lorenzwalthert]

I think the reason this might seem inconsistent with the other test is that there is no space around ^ in any of the other *-out.R files, but I think that is because in all *-in.R files, we always have x^k(so no space in between) and hence the tests don't actually test whether x ^ k is turned into x^k.

[lorenzwalthert]

Thanks. I think as mentioned in the comment above, do you think strict = FALSE should remove spaces around ^? If yes, we need to adapt.

[krlmlr]

I've updated the code, because we're removing spaces for : too:

styler::style_text("1 : 10", strict = FALSE)
#> 1:10
styler::style_text("1 ^ 10", strict = FALSE)
#> 1^10

Created on 2018-02-23 by the reprex package (v0.2.0).

[lorenzwalthert]

Great. It payed off to reduce some duplication and encapsulate common functionality in style_space_around_token().