Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named arguments and line breaks #318

Merged
merged 2 commits into from Jan 6, 2018

Conversation

@lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Jan 6, 2018

Closes #246.

explicitly find the position (and don't just take the position after the opening parenthesis) at which a line break should be inserted in a multi-line call.
@codecov-io
Copy link

@codecov-io codecov-io commented Jan 6, 2018

Codecov Report

Merging #318 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
+ Coverage   91.17%   91.19%   +0.01%     
==========================================
  Files          30       30              
  Lines        1371     1374       +3     
==========================================
+ Hits         1250     1253       +3     
  Misses        121      121
Impacted Files Coverage Δ
R/rules-line_break.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1631426...3b84c6c. Read the comment docs.

Loading

@lorenzwalthert lorenzwalthert merged commit d4abea3 into r-lib:master Jan 6, 2018
4 checks passed
Loading
@lorenzwalthert lorenzwalthert deleted the named-arguments branch Jan 6, 2018
@lorenzwalthert
Copy link
Collaborator Author

@lorenzwalthert lorenzwalthert commented Feb 25, 2018

Reference: #342.

Loading

@lorenzwalthert lorenzwalthert mentioned this pull request Mar 2, 2018
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants