Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove implicit dplyr dependency #324

Merged
merged 1 commit into from Jan 18, 2018

Conversation

Projects
None yet
3 participants
@lorenzwalthert
Copy link
Collaborator

lorenzwalthert commented Jan 17, 2018

Closes #323.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 17, 2018

Codecov Report

Merging #324 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
+ Coverage    91.2%   91.22%   +0.01%     
==========================================
  Files          30       30              
  Lines        1376     1379       +3     
==========================================
+ Hits         1255     1258       +3     
  Misses        121      121
Impacted Files Coverage Δ
R/relevel.R 100% <ø> (ø) ⬆️
R/dplyr.R 89.02% <100%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d71bc2...240dc52. Read the comment docs.

@krlmlr

krlmlr approved these changes Jan 18, 2018

Copy link
Member

krlmlr left a comment

Looks good, thanks!

@lorenzwalthert lorenzwalthert merged commit de6358f into r-lib:master Jan 18, 2018

4 checks passed

codecov/patch 100% of diff hit (target 91.2%)
Details
codecov/project 91.22% (+0.01%) compared to 1d71bc2
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lorenzwalthert lorenzwalthert deleted the lorenzwalthert:hotfix-dplyr branch Jan 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.