Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Only replace long strings #384
Another attempt to solve #216, by implementing suggestion 2 suggested in #216 (comment). That is, only replace the strings that are necessary, not all strings if there is one string in the parse data that is longer than 1'000. This does (not yet) implement line / col substitution but returns an error if there is a problem, so we are failing fast instead of silently. I think it's rather unlikely that this is going to cause a problem in the future.
Also closes #383.
@krlmlr there seems to be a bug in the R base parser of
referenced this pull request
Apr 3, 2018
@@ Coverage Diff @@ ## master #384 +/- ## ========================================== - Coverage 91.68% 91.02% -0.67% ========================================== Files 30 30 Lines 1479 1526 +47 ========================================== + Hits 1356 1389 +33 - Misses 123 137 +14