Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept engine-agnostic code in .Rmd #386

Merged
merged 3 commits into from Apr 3, 2018

Conversation

Projects
None yet
2 participants
@lorenzwalthert
Copy link
Collaborator

lorenzwalthert commented Apr 2, 2018

Closes #385.

@lorenzwalthert lorenzwalthert changed the title accept engine-agnostic code in .Rmd Accept engine-agnostic code in .Rmd Apr 2, 2018

@lorenzwalthert lorenzwalthert force-pushed the lorenzwalthert:rmd branch 4 times, most recently from fbdd1f0 to e8d8ba7 Apr 2, 2018

lorenzwalthert added some commits Apr 2, 2018

Allow for enigne agnistic code.
find chunk start and ends via odd / even regex matches that are engine agnostic.

@lorenzwalthert lorenzwalthert force-pushed the lorenzwalthert:rmd branch from e8d8ba7 to 5b376f4 Apr 3, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 3, 2018

Codecov Report

Merging #386 into master will decrease coverage by 0.1%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
- Coverage   91.79%   91.68%   -0.11%     
==========================================
  Files          30       30              
  Lines        1474     1479       +5     
==========================================
+ Hits         1353     1356       +3     
- Misses        121      123       +2
Impacted Files Coverage Δ
R/transform-code.R 95% <100%> (+0.12%) ⬆️
R/utils.R 85.18% <50%> (-6.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1fe62f...5b376f4. Read the comment docs.

@lorenzwalthert lorenzwalthert merged commit ea6dcd6 into r-lib:master Apr 3, 2018

2 of 4 checks passed

codecov/patch 71.42% of diff hit (target 91.79%)
Details
codecov/project 91.68% (-0.11%) compared to a1fe62f
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lorenzwalthert lorenzwalthert deleted the lorenzwalthert:rmd branch Apr 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.