Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New README #413

Merged
merged 1 commit into from Jul 29, 2018
Merged

New README #413

merged 1 commit into from Jul 29, 2018

Conversation

@lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Jul 28, 2018

Closes #32. @krlmlr do you want to have a look? You can have a preview available on my fork.

@lorenzwalthert lorenzwalthert requested a review from krlmlr Jul 28, 2018
@codecov-io
Copy link

@codecov-io codecov-io commented Jul 28, 2018

Codecov Report

Merging #413 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #413   +/-   ##
======================================
  Coverage    91.8%   91.8%           
======================================
  Files          34      34           
  Lines        1550    1550           
======================================
  Hits         1423    1423           
  Misses        127     127

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98a2c48...6e10a12. Read the comment docs.

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Jul 29, 2018

Thanks. Looks good, I like it!

@lorenzwalthert lorenzwalthert merged commit c6d860f into r-lib:master Jul 29, 2018
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing 98a2c48...6e10a12
Details
codecov/project 91.8% remains the same compared to 98a2c48
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lorenzwalthert lorenzwalthert deleted the lorenzwalthert:readme branch Jul 29, 2018
@lorenzwalthert
Copy link
Collaborator Author

@lorenzwalthert lorenzwalthert commented Jul 29, 2018

Here we go. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants