New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace enc with xfun #442

Merged
merged 4 commits into from Nov 18, 2018

Conversation

Projects
None yet
2 participants
@lorenzwalthert
Collaborator

lorenzwalthert commented Nov 16, 2018

Substituting enc's read and write functionality with xfun and re-implement enc::transform_lines_enc() in R/io.R. Closes #439.

replace enc with xfun
Substituting enc's read and write functionality with xfun and re-implement enc::transform_lines_enc() in R/io.R

@lorenzwalthert lorenzwalthert force-pushed the lorenzwalthert:remove-enc branch from 903fbff to 8458b93 Nov 18, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Nov 18, 2018

Codecov Report

Merging #442 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
+ Coverage   90.94%   91.01%   +0.06%     
==========================================
  Files          35       36       +1     
  Lines        1613     1625      +12     
==========================================
+ Hits         1467     1479      +12     
  Misses        146      146
Impacted Files Coverage Δ
R/ui.R 100% <ø> (ø) ⬆️
R/transform-files.R 100% <100%> (ø) ⬆️
R/roxygen-examples-find.R 100% <100%> (ø) ⬆️
R/io.R 100% <100%> (ø)
R/transform-code.R 96% <100%> (ø) ⬆️
R/testing.R 73.19% <100%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f61328...8002a9d. Read the comment docs.

@lorenzwalthert lorenzwalthert force-pushed the lorenzwalthert:remove-enc branch from 250926a to 8002a9d Nov 18, 2018

@lorenzwalthert lorenzwalthert merged commit 9f6b57a into r-lib:master Nov 18, 2018

4 checks passed

codecov/patch 100% of diff hit (target 90.94%)
Details
codecov/project 91.01% (+0.06%) compared to 7f61328
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lorenzwalthert lorenzwalthert deleted the lorenzwalthert:remove-enc branch Nov 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment