Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix texts #484

Merged
merged 3 commits into from Mar 15, 2019

Conversation

@lorenzwalthert
Copy link
Collaborator

commented Mar 15, 2019

Closes #483 by fixing typo. Includes some other minor improvements.

lorenzwalthert added some commits Mar 15, 2019

refer to variable in functino scope
Otherwise, this will refer to the globally defined text variable or function, which leads to odd situations when text has length greater one in the remainder of this function.

@lorenzwalthert lorenzwalthert force-pushed the lorenzwalthert:hotfix-texts branch from d5be4d1 to e54f560 Mar 15, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Mar 15, 2019

Codecov Report

Merging #484 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #484   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files          36       36           
  Lines        1650     1650           
=======================================
  Hits         1480     1480           
  Misses        170      170
Impacted Files Coverage Δ
R/token-create.R 95.65% <100%> (ø) ⬆️
R/transform-files.R 100% <100%> (ø) ⬆️
R/relevel.R 97.01% <100%> (ø) ⬆️
R/nest.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eed2c4...e54f560. Read the comment docs.

@lorenzwalthert lorenzwalthert merged commit 56b48aa into r-lib:master Mar 15, 2019

4 checks passed

codecov/patch 100% of diff hit (target 89.69%)
Details
codecov/project 89.69% (+0%) compared to 4eed2c4
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lorenzwalthert lorenzwalthert deleted the lorenzwalthert:hotfix-texts branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.