Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in R parser makes styler fail on R devel #583

Merged
merged 2 commits into from Feb 9, 2020

Conversation

lorenzwalthert
Copy link
Collaborator

Closes #582.

@codecov-io
Copy link

codecov-io commented Feb 2, 2020

Codecov Report

Merging #583 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
+ Coverage    90.6%   90.67%   +0.06%     
==========================================
  Files          46       46              
  Lines        2044     2048       +4     
==========================================
+ Hits         1852     1857       +5     
+ Misses        192      191       -1
Impacted Files Coverage Δ
R/environments.R 100% <100%> (ø) ⬆️
R/utils.R 80.76% <0%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91df2a3...178f8f3. Read the comment docs.

@lorenzwalthert
Copy link
Collaborator Author

I thought this one should fail but it does not: https://travis-ci.org/lorenzwalthert/styler/builds/645177749?utm_medium=notification&utm_source=github_status

Is R-devel outdated?

@lorenzwalthert lorenzwalthert merged commit a05de07 into r-lib:master Feb 9, 2020
@lorenzwalthert lorenzwalthert deleted the issue-582 branch February 9, 2020 16:37
@lorenzwalthert lorenzwalthert restored the issue-582 branch November 28, 2020 11:31
@lorenzwalthert lorenzwalthert deleted the issue-582 branch September 11, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

R devel operator precedence fix makes styler fail on CRAN
2 participants