Skip to content

Correctly identify block with caching and comments #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Feb 13, 2020

Closes #592. Note that #592 contained two different issues. The first one was fixed in #594 and the second is fixed here. They are both related to caching but not related to each other.

@lorenzwalthert lorenzwalthert merged commit 6b1dbfa into r-lib:master Feb 13, 2020
@lorenzwalthert lorenzwalthert deleted the issue-952-2 branch February 13, 2020 15:02
@codecov-io
Copy link

codecov-io commented Feb 13, 2020

Codecov Report

Merging #595 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #595   +/-   ##
=======================================
  Coverage   92.12%   92.12%           
=======================================
  Files          47       47           
  Lines        2095     2095           
=======================================
  Hits         1930     1930           
  Misses        165      165
Impacted Files Coverage Δ
R/nest.R 100% <ø> (ø) ⬆️
R/transform-block.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fce44c...ad8085d. Read the comment docs.

@lorenzwalthert lorenzwalthert restored the issue-952-2 branch November 28, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with caching
2 participants