Make styler ignore work when tokens are modified #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a stylerignore sequence. Previously, all non-terminals were set to FALSE. This new implementation is required when creating new tokens (e.g. wrap_expr_in_curly()) and we don't want to make assumptions about the structure of the child to find out whether it's stylerignore or not. Hence, we can just check if the tokens to wrap are stylerignore or not, no matter whether or not they are terminals.
Do apply stylerignore based on the pos_id of the first token in the sequence (the start marker) and not 1:1 for every token in the stylerignore sequence. The latter would not work if tokens are added or removed.
Codecov Report
@@ Coverage Diff @@
## master #602 +/- ##
==========================================
+ Coverage 92.12% 92.18% +0.05%
==========================================
Files 47 47
Lines 2096 2110 +14
==========================================
+ Hits 1931 1945 +14
Misses 165 165
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Closes #599.