Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip timing tests on CRAN #603

Merged
merged 5 commits into from Feb 19, 2020
Merged

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Feb 19, 2020

Closes #597 by adding skip_on_cran() in relevant test that sections as requested by CRAN to make tests pass.

@codecov-io
Copy link

codecov-io commented Feb 19, 2020

Codecov Report

Merging #603 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #603   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files          47       47           
  Lines        2110     2110           
=======================================
  Hits         1945     1945           
  Misses        165      165

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06b4eae...56bbaa4. Read the comment docs.

@lorenzwalthert lorenzwalthert merged commit 3760ce1 into r-lib:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve timing benchmarks in CI and disable on CRAN
2 participants