Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also test on macOS #604

Merged
merged 4 commits into from Feb 20, 2020
Merged

Also test on macOS #604

merged 4 commits into from Feb 20, 2020

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Feb 19, 2020

Local macOS test environment, there was a problem with the public API tests because the cli package seems to return slightly differently and coded symbols for tick and cross. Strangely though, this problem doesn’t appear on Travis.

@codecov-io
Copy link

codecov-io commented Feb 20, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@3760ce1). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #604   +/-   ##
=========================================
  Coverage          ?   90.46%           
=========================================
  Files             ?       47           
  Lines             ?     2128           
  Branches          ?        0           
=========================================
  Hits              ?     1925           
  Misses            ?      203           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3760ce1...8a9ec16. Read the comment docs.

@lorenzwalthert lorenzwalthert merged commit 0797fc8 into r-lib:master Feb 20, 2020
@lorenzwalthert lorenzwalthert changed the title Test on macOS Also test on macOS Feb 20, 2020
@lorenzwalthert lorenzwalthert deleted the test-osx branch February 20, 2020 08:28
@lorenzwalthert lorenzwalthert restored the test-osx branch November 28, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants