Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't modify token for edge cases styler ignore #611

Merged
merged 5 commits into from Feb 22, 2020

Conversation

lorenzwalthert
Copy link
Collaborator

When curly braces would be needed, but any token in the expression to put braces around is styler ignored, leave it. Closes #606.

…t in stylerignore because the parse table will be shallow
…o keep it in stylerignore because the parse table will be shallow"

Apparently this is not necessary.
This reverts commit fd6dfff.
…e activated it at some point. All tests that are not explicit cache tests should not use it.
@codecov-io
Copy link

codecov-io commented Feb 22, 2020

Codecov Report

Merging #611 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #611      +/-   ##
==========================================
+ Coverage   90.53%   90.53%   +<.01%     
==========================================
  Files          47       47              
  Lines        2144     2145       +1     
==========================================
+ Hits         1941     1942       +1     
  Misses        203      203
Impacted Files Coverage Δ
R/rules-other.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8372af2...d7cf178. Read the comment docs.

@lorenzwalthert lorenzwalthert merged commit 6e96dac into r-lib:master Feb 22, 2020
@lorenzwalthert lorenzwalthert deleted the issue-606 branch February 22, 2020 19:21
@lorenzwalthert lorenzwalthert restored the issue-606 branch November 28, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caching conflicts with in-line stylerignore
2 participants