Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tokens instead of token in doc #643

Merged
merged 2 commits into from Jun 1, 2020
Merged

Conversation

renkun-ken
Copy link
Contributor

No description provided.

@lorenzwalthert
Copy link
Collaborator

Thanks. You forgot to roxygenize 😄. Can you do this and push again? We' are not (yet) using gh actions. Also, to prevent in the future, I'll add a note to CONTRIBUTING.md on how to use pre-commit as a contributor.

@renkun-ken
Copy link
Contributor Author

Actually I tried but the following error occurs:

> roxygen2::roxygenize()                                                                                                                                                              
Error in loadNamespace(name) : there is no package called 'pkgapi'
Backtrace:
1: stop(cond)
2: doWithOneRestart(return(expr), restart)
3: withOneRestart(expr, restarts[[1L]])
4: withRestarts(stop(cond), retry_loadNamespace = function() NULL)
5: loadNamespace(name)
6: getNamespace(ns)
7: asNamespace(ns)
8: getExportedValue(pkg, name)
9: pkgapi::api_roclet
10: eval(expr, env)
11: eval(expr, env)
12: FUN(X[[i]], ...)
13: lapply(roclets, roclet_find)
14: roxygen2::roxygenize()

> install.packages("pkgapi")                                                                                                                                                          
Installing package into '/home/renkun/R/x86_64-pc-linux-gnu-library/4.0'
(as 'lib' is unspecified)
Warning message:
package 'pkgapi' is not available (for R version 4.0.0) 

I guess I'm missing something?

@lorenzwalthert
Copy link
Collaborator

lorenzwalthert commented Jun 1, 2020

Jup, it's not yet on CRAN: https://github.com/r-lib/pkgapi. Once it is, we'll add it to Suggests.

@renkun-ken
Copy link
Contributor Author

Thanks! Just roxygenized.

@lorenzwalthert
Copy link
Collaborator

Also, CI fails seem unrelated. Any idea? I opened r-lib/backports#35 so we could import that function from {backports} maybe, but not sure it works that way.

@lorenzwalthert
Copy link
Collaborator

Thanks

@lorenzwalthert lorenzwalthert merged commit a00c57f into r-lib:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants