New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmarking infra #674
Conversation
Codecov Report
@@ Coverage Diff @@
## master #674 +/- ##
=======================================
Coverage 90.42% 90.42%
=======================================
Files 47 47
Lines 2224 2224
=======================================
Hits 2011 2011
Misses 213 213 Continue to review full report at Codecov.
|
af42f8f
to
3751fc2
Compare
bench/01-declarations.R
Outdated
file = paste0("plots/", new_bm_label, ".pdf")) { | ||
new_bm <- bench::as_bench_mark(new_bm) | ||
branches <- gert::git_branch_list() | ||
master <- branches[branches$name == "master", "commit", drop = TRUE] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make this more generic for target branch != master.
bench/01-declarations.R
Outdated
#' @param new_bm A new benchmark object. | ||
#' @param new_bm_label The label of the new benchmark used as a title. | ||
#' @param file The file path to write the plot. | ||
plot_against_master <- function(new_bm, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more generic, not just master (also in title).
Codecov Report
@@ Coverage Diff @@
## master #674 +/- ##
=======================================
Coverage 90.43% 90.43%
=======================================
Files 47 47
Lines 2226 2226
=======================================
Hits 2013 2013
Misses 213 213 Continue to review full report at Codecov.
|
a5f650e
to
b49dd1a
Compare
e4762d5
to
98ca368
Compare
This is only relevant on first fetch when there are no benchmarks yet
42d1a37
to
ad5ed3d
Compare
ad5ed3d
to
b663a40
Compare
Using
bench::mark()
and friends, we build a continuous benchmarking system. For any PR there is, we create a boxplot to visualise the distribution for timings for the base branch (e.g. master) and the branch we want to merge into the base branch (head) in one plot.Todo:
bench/
directly. We should probably run two styler commands - Some files should be partly styled to test caching of top level expressions.name
arugment inbench::mark()
.