Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exclude_dirs for recursive case #676

Merged
merged 4 commits into from Oct 4, 2020

Conversation

lorenzwalthert
Copy link
Collaborator

Closes #675.

@codecov-commenter
Copy link

Codecov Report

Merging #676 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #676   +/-   ##
=======================================
  Coverage   90.42%   90.43%           
=======================================
  Files          47       47           
  Lines        2224     2226    +2     
=======================================
+ Hits         2011     2013    +2     
  Misses        213      213           
Impacted Files Coverage Δ
R/ui-styling.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3555174...cb57f2d. Read the comment docs.

NEWS.md Outdated
@@ -21,6 +21,8 @@

## Minor changes and fixes

- `style_dir()` and friends now apply directory exclusion recursively with

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we be explicit since the only other function that currently does that is style_pkg?

style_dir() and style_pkg() now apply directory exclusion recursively with

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Did yoy know about the 'Insert Suggestion' tool? You can directly suggest a new commit on GitHub. It will pre-fill the suggestion with the current content and you can adapt and suggest. See here too.
Screenshot 2020-10-04 at 10 35 42

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know about it. Thanks for sharing!

NEWS.md Outdated Show resolved Hide resolved
@lorenzwalthert lorenzwalthert merged commit c7e7b70 into r-lib:master Oct 4, 2020
@lorenzwalthert lorenzwalthert deleted the issue-657 branch October 4, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

style_dir() exclude_dirs is not recursive to sub directories
3 participants