New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exclude_dirs for recursive case #676
Conversation
Codecov Report
@@ Coverage Diff @@
## master #676 +/- ##
=======================================
Coverage 90.42% 90.43%
=======================================
Files 47 47
Lines 2224 2226 +2
=======================================
+ Hits 2011 2013 +2
Misses 213 213
Continue to review full report at Codecov.
|
NEWS.md
Outdated
@@ -21,6 +21,8 @@ | |||
|
|||
## Minor changes and fixes | |||
|
|||
- `style_dir()` and friends now apply directory exclusion recursively with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we be explicit since the only other function that currently does that is style_pkg?
style_dir()
andstyle_pkg()
now apply directory exclusion recursively with
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Did yoy know about the 'Insert Suggestion' tool? You can directly suggest a new commit on GitHub. It will pre-fill the suggestion with the current content and you can adapt and suggest. See here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't know about it. Thanks for sharing!
Closes #675.