Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use magrittr 2.0 #681

Merged
merged 2 commits into from Nov 24, 2020
Merged

use magrittr 2.0 #681

merged 2 commits into from Nov 24, 2020

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Oct 18, 2020

Check how this affects speed. Local benchmarks showed ~ 8.1% diff (#664).

Let's see remote benchmarks

> (4 - 3.7) / 3.7
[1] 0.08108108

Ok, pretty close!

  • cache_appyling: 0.031 -> 0.029 (-9%)
  • cache_recording: 1.078 -> 0.966 (-10%)
  • without_cache: 3.162 -> 2.834 (-10%)

@codecov-io
Copy link

codecov-io commented Oct 18, 2020

Codecov Report

Merging #681 (59ca5e6) into master (c50338f) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #681      +/-   ##
==========================================
- Coverage   90.43%   90.41%   -0.02%     
==========================================
  Files          47       47              
  Lines        2226     2223       -3     
==========================================
- Hits         2013     2010       -3     
  Misses        213      213              
Impacted Files Coverage Δ
R/set-assert-args.R 92.30% <0.00%> (-0.38%) ⬇️
R/utils-cache.R 100.00% <0.00%> (ø)
R/rules-line-break.R 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c50338f...59ca5e6. Read the comment docs.

now on CRAN
@lorenzwalthert lorenzwalthert changed the title use magrittr devel version use magrittr 2.0 Nov 24, 2020
@lorenzwalthert lorenzwalthert merged commit 26f9f59 into r-lib:master Nov 24, 2020
@lorenzwalthert lorenzwalthert deleted the issue-664 branch November 24, 2020 18:07
@lorenzwalthert lorenzwalthert mentioned this pull request Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants