Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add one more benchmark plot on recording for cache only #684

merged 43 commits into from Oct 25, 2020


Copy link

@lorenzwalthert lorenzwalthert commented Oct 21, 2020

This PR

  • switches to checkpoint of RStudio Package Manager and hence fix all versions of all dependencies for better comparison.
  • Wanted to introduce a PR comment bot but it did not work with various action providers because apparently, commenting on PRs from forks is not really solved with GitHub Actions yet.
  • introduced a new benchmark for first stying with empty cache, tied to a git reset HEAD --hard, called cache_recording. It reflects the situation when you have the cache feature turned on and style code that was never styled before. This is the most common case I think.
  • Make the action where the cache is activated (cache_recording) comparable with where it's not (without_cache) by simulate the git reset in the latter (so they are equal up to the caching feature).

Copy link

codecov-io commented Oct 21, 2020

Codecov Report

Merging #684 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #684   +/-   ##
  Coverage   90.43%   90.43%           
  Files          47       47           
  Lines        2226     2226           
  Hits         2013     2013           
  Misses        213      213           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c50338f...5f34131. Read the comment docs.

@lorenzwalthert lorenzwalthert merged commit 4905fc5 into r-lib:master Oct 25, 2020
2 checks passed
@lorenzwalthert lorenzwalthert deleted the issue-680 branch October 25, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants