Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #686 #687

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Fixes #686 #687

merged 1 commit into from
Oct 26, 2020

Conversation

espinielli
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #687 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #687   +/-   ##
=======================================
  Coverage   90.43%   90.43%           
=======================================
  Files          47       47           
  Lines        2226     2226           
=======================================
  Hits         2013     2013           
  Misses        213      213           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4905fc5...19984c7. Read the comment docs.

@lorenzwalthert
Copy link
Collaborator

Thanks @espinielli. If you check the devel doc page of styler at https://styler.r-lib.org/dev/, you'd actually see that the problem is already fixed there, but not so nicely (just c/p output, not evaluating create_tree(), so I agree we should use this PR. Sidenote: create_tree() currently only works with caching deactivated (which happens to be the case in this vignette), so I created #688.

@lorenzwalthert lorenzwalthert merged commit e1cdd59 into r-lib:master Oct 26, 2020
@lorenzwalthert
Copy link
Collaborator

actually this does not work because data.tree is required to run this function and it does not exist on R < 3.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants