Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor speed improvements #691

Merged
merged 5 commits into from Nov 26, 2020

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Nov 3, 2020

Probably wrong benchmarks, local tests showed ~ -5%.
d82c7e0

  • cache_appyling: 0.048 -> 0.039 (-18%)
  • cache_recording: 1.483 -> 1.055 (-29%)
  • without_cache: 4.384 -> 3.136 (-28%)

3380aa7

  • cache_appyling: 0.048 -> 0.034 (-28%)
  • cache_recording: 1.483 -> 0.918 (-38%)
  • without_cache: 4.384 -> 2.773 (-37%)

new benchmarks show around 3% improvement.

@codecov-io
Copy link

Codecov Report

Merging #691 (3380aa7) into master (a2a2e2e) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #691      +/-   ##
==========================================
- Coverage   90.42%   90.34%   -0.09%     
==========================================
  Files          47       47              
  Lines        2225     2226       +1     
==========================================
- Hits         2012     2011       -1     
- Misses        213      215       +2     
Impacted Files Coverage Δ
R/compat-dplyr.R 85.71% <100.00%> (-4.53%) ⬇️
R/compat-tidyr.R 100.00% <100.00%> (ø)
R/indent.R 100.00% <100.00%> (ø)
R/initialize.R 96.96% <100.00%> (-0.09%) ⬇️
R/nest.R 100.00% <100.00%> (ø)
R/transform-files.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2a2e2e...3380aa7. Read the comment docs.

@lorenzwalthert lorenzwalthert merged commit ca437ba into r-lib:master Nov 26, 2020
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants