Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sorting #739

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Feb 27, 2021

Avoids duplicate sorting which might bring speed gain.


Here is how the current PR would change benchmark results when merged into master:

  • cache_applying: 0.03 -> 0.03 (-0.1%)
  • cache_recording: 1.28 -> 1.28 (0.1%)
  • without_cache: 3.97 -> 3.77 (-5.1%)

@lorenzwalthert lorenzwalthert merged commit e0b8557 into r-lib:master Feb 27, 2021
@lorenzwalthert lorenzwalthert deleted the speed-up-left-join-with-disabling-sorting branch February 27, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant