Skip to content

Add base_indention for cached top-level expression#764

Merged
lorenzwalthert merged 3 commits intor-lib:masterfrom
lorenzwalthert:issue-763
Mar 30, 2021
Merged

Add base_indention for cached top-level expression#764
lorenzwalthert merged 3 commits intor-lib:masterfrom
lorenzwalthert:issue-763

Conversation

@lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Mar 29, 2021

Closes #763.

Here is how the current PR would change benchmark results when merged into master:

cache_applying: 0.03 -> 0.03 (1.7%)
cache_recording: 1.1 -> 1.09 (-0.3%)
without_cache: 3.28 -> 3.26 (-0.5%)

cache_applying: 0.02 -> 0.02 (-2.1%)
cache_recording: 0.74 -> 0.74 (-1.3%)
without_cache: 2.15 -> 2.2 (2.2%)

cache_applying: 0.03 -> 0.03 (-0.5%)
cache_recording: 1 -> 1 (-0.5%)
without_cache: 2.9 -> 2.94 (1.5%)

@lorenzwalthert lorenzwalthert changed the title Add base indention for top level expression Add base_indention for top cached top-level expression Mar 30, 2021
@lorenzwalthert lorenzwalthert changed the title Add base_indention for top cached top-level expression Add base_indention for cached top-level expression Mar 30, 2021
@lorenzwalthert lorenzwalthert merged commit ac7e98f into r-lib:master Mar 30, 2021
@lorenzwalthert lorenzwalthert deleted the issue-763 branch March 30, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent behavior of base_indention

1 participant