Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support left alignment in tribble #785

Merged
merged 5 commits into from Apr 30, 2021

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Apr 29, 2021

Closes #784 and toward #258. Now supporting:

tibble::tribble(
   ~x,       ~d,
   "axa'fa", 1:6,
   "b",      4:6
 )
  • cache_applying: 0.03 -> 0.02 (-7.5%)
  • cache_recording: 0.88 -> 0.86 (-3%)
  • without_cache: 2.65 -> 2.55 (-3.7%)

(This is actually not very realistic)

With an alinged tibble in benchmarking code:

  • cache_applying: 0.03 -> 0.03 (-1%)
  • cache_recording: 1.58 -> 1.58 (0.1%)
  • without_cache: 4.12 -> 4.12 (0%)

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2021

Codecov Report

Merging #785 (97e2984) into master (073a3ec) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 97e2984 differs from pull request most recent head 415258d. Consider uploading reports for the commit 415258d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #785      +/-   ##
==========================================
+ Coverage   90.55%   90.64%   +0.08%     
==========================================
  Files          47       47              
  Lines        2393     2416      +23     
==========================================
+ Hits         2167     2190      +23     
  Misses        226      226              
Impacted Files Coverage Δ
R/detect-alignment-utils.R 90.47% <100.00%> (ø)
R/detect-alignment.R 98.48% <100.00%> (+0.75%) ⬆️
R/indent.R 100.00% <100.00%> (ø)
R/initialize.R 96.96% <100.00%> (ø)
R/rules-line-breaks.R 100.00% <100.00%> (ø)
R/rules-tokens.R 100.00% <100.00%> (ø)
R/serialize.R 100.00% <100.00%> (ø)
R/token-create.R 95.91% <100.00%> (ø)
R/unindent.R 95.65% <100.00%> (ø)
R/visit.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51bb82f...415258d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

detect tribble-like alignment
2 participants