Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styler.quiet should be respected in cache utils #797

Merged
merged 5 commits into from
May 12, 2021

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented May 9, 2021

Closes #796.

  • cache_applying (issue-796 -> master):
    0.12 (± 0.01) -> 0.12 (± 0.01): (0%)
  • cache_recording (issue-796 -> master): 1.64 (± 0.03) -> 1.64 (± 0.04): (0%)
  • without_cache (issue-796 -> master): 4.16 (± 0.05) -> 4.16 (± 0.05): (0%)

New version:

Here is how the current PR would change benchmark results when merged into master:

  • cache_applying (merge issue-796 into master): 0.12 -> 0.12 [-0.96%, +7.66%]
  • cache_recording (merge issue-796 into master): 1.61 -> 1.62 [-0.01%, +1.6%]
  • without_cache (merge issue-796 into master): 4.23 -> 4.25 [-0.3%, +1.21%]

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2021

Codecov Report

Merging #797 (60ba86f) into master (7411151) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #797   +/-   ##
=======================================
  Coverage   90.46%   90.46%           
=======================================
  Files          47       47           
  Lines        2433     2433           
=======================================
  Hits         2201     2201           
  Misses        232      232           
Impacted Files Coverage Δ
R/ui-caching.R 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7411151...60ba86f. Read the comment docs.

@lorenzwalthert lorenzwalthert merged commit 571406e into r-lib:master May 12, 2021
@lorenzwalthert lorenzwalthert deleted the issue-796 branch May 12, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cache utils should respect R option styler.quiet
2 participants