Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing infra #798

Merged
merged 14 commits into from Sep 11, 2021
Merged

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented May 9, 2021

Todo: test-public-api can also use some silencing of messages...

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2021

Codecov Report

Merging #798 (8a30c72) into master (2b1eeac) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #798      +/-   ##
==========================================
- Coverage   90.60%   90.47%   -0.14%     
==========================================
  Files          47       47              
  Lines        2460     2468       +8     
==========================================
+ Hits         2229     2233       +4     
- Misses        231      235       +4     
Impacted Files Coverage Δ
R/ui-caching.R 90.24% <ø> (-9.76%) ⬇️
R/testing.R 79.56% <100.00%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b1eeac...8a30c72. Read the comment docs.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confience interval in relative change) if 4e97d8e and ancestors are merged into master:

  • cache_applying: 0.1s -> 0.1s [-1.73%, +6.67%]
  • cache_recording: 1.22s -> 1.23s [-0.1%, +1.78%]
  • without_cache: 3.23s -> 3.19s [-1.98%, -0.27%]

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confience interval in relative change) if 5450ce6 and ancestors are merged into master:

  • cache_applying: 0.09s -> 0.09s [-0.86%, +5.27%]
  • cache_recording: 1.03s -> 1.03s [-0.23%, +0.44%]
  • without_cache: 2.66s -> 2.66s [-0.04%, +0.49%]

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confience interval in relative change) if 0cb38f5 and ancestors are merged into master:

  • cache_applying: 0.09s -> 0.09s [-1.85%, +4.89%]
  • cache_recording: 1.16s -> 1.16s [-0.32%, +0.74%]
  • without_cache: 3.01s -> 3.01s [-0.31%, +0.52%]

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confience interval in relative change) if c27b512 and ancestors are merged into master:

  • cache_applying: 0.09s -> 0.09s [-2.75%, +3.86%]
  • cache_recording: 1.14s -> 1.15s [-0.35%, +0.97%]
  • without_cache: 2.99s -> 2.99s [-0.49%, +0.29%]

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confience interval in relative change) if 383d0b2 and ancestors are merged into master:

  • cache_applying: 0.11s -> 0.11s [-1.55%, +5.39%]
  • cache_recording: 1.11s -> 1.12s [-0.25%, +1.64%]
  • without_cache: 2.96s -> 2.96s [-1%, +1.28%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confience interval in relative change) if dcf8bec is merged into master:

  • cache_applying: 0.11s -> 0.11s [-4.25%, +2.72%]
  • cache_recording: 1.46s -> 1.46s [-1.73%, +0.48%]
  • without_cache: 3.88s -> 3.88s [-0.48%, +0.67%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2021

This is how benchmark results would change (along with a 95% confience interval in relative change) if 02a02ed is merged into master:

  • cache_applying: 0.06s -> 0.06s [-1.04%, +6.55%]
  • cache_recording: 1.35s -> 1.35s [-1.35%, +1.79%]
  • without_cache: 3.71s -> 3.72s [-0.85%, +1.48%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert marked this pull request as ready for review June 9, 2021 13:55
@lorenzwalthert lorenzwalthert merged commit f7cea77 into r-lib:master Sep 11, 2021
@lorenzwalthert lorenzwalthert deleted the testing-infra branch September 11, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants